Add creatuity/magento2-interceptors as a bundled extension#206
Conversation
|
I love this addition. However I have a confidence check.
Is there any current standing area where this is reproduced? Absence of reproduction isn't always an indicator of working as intended, as it may be specific edgecases, but if there's a somewhere that has reproducible steps to show it was an issue in 2.4.X-px (x=Whatever the latest version as of the first report) and now we see those steps no longer reproduce I'd be all for it. I only bring this up because it reads not as "We confidently can say this no longer exists" and more of "We believe but have no confirmation". Update: Confident Mels PR solves the issue from local testing |
You can see the tracking issue or help out at creatuity/magento2-interceptors#14 . |
I propose adding Creatuity_Interception as a bundled module with the upcoming Mage-OS 1.1.0. https://github.com/creatuity/magento2-interceptors
Implications
compiled_pluginscache type to be enabled or disabled on sites (optional opt-in)Risks
pluginnameand another haspluginNameon the same class, only one will be compiled and executed). I've never seen this situation arise, and would argue it's bad practice in the first place.Benefits
PR
This PR results in the module being added as a pinned require of
mage-os/product-community-editionlike:which composer will then require via packagist, like any other third party package (Monolog, Laminas, Symphony, ...).